Thread (3 messages) 3 messages, 3 authors, 2017-07-14

Re: [PATCH] thermal: qcom: tsens: fix crash due to incorrect __init

From: Bjorn Andersson <hidden>
Date: 2017-06-30 21:22:34
Also in: linux-arm-msm

On Fri 30 Jun 13:40 PDT 2017, Rob Clark wrote:
init_common() is called from probe, which can happen after the __init
section is already unloaded in the case of -EPROBE_DEFER.  Causing a
later probe to attempt to branch to hyperspace.

Cc: <redacted>
Signed-off-by: Rob Clark <redacted>
Acked-by: Bjorn Andersson <redacted>

Regards,
Bjorn
quoted hunk ↗ jump to hunk
---
 drivers/thermal/qcom/tsens-common.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/thermal/qcom/tsens-common.c b/drivers/thermal/qcom/tsens-common.c
index b1449ad..22ad37c 100644
--- a/drivers/thermal/qcom/tsens-common.c
+++ b/drivers/thermal/qcom/tsens-common.c
@@ -123,7 +123,7 @@ static const struct regmap_config tsens_config = {
 	.reg_stride	= 4,
 };
 
-int __init init_common(struct tsens_device *tmdev)
+int init_common(struct tsens_device *tmdev)
 {
 	void __iomem *base;
 
-- 
2.9.4
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help