Thread (7 messages) 7 messages, 3 authors, 2016-12-28

Re: [PATCH v2 01/46] mtdpart: Propagate _get/put_device()

From: Karl Beldan <hidden>
Date: 2016-12-15 07:09:20
Also in: lkml

On Wed, Dec 14, 2016 at 9:09 PM, Brian Norris
[off-list ref] wrote:
On Wed, Dec 14, 2016 at 07:24:46PM +0000, Karl Beldan wrote:
quoted
On Wed, Sep 28, 2016 at 8:16 PM, Brian Norris
[off-list ref] wrote:
quoted
On Wed, Sep 21, 2016 at 12:15:31PM +0200, Boris Brezillon wrote:
quoted
On Wed, 21 Sep 2016 11:43:56 +0200
Daniel Walter [off-list ref] wrote:
quoted
From: Richard Weinberger <richard@nod.at>

If the master device has callbacks for _get/put_device()
and this MTD has slaves a get_mtd_device() call on paritions
will never issue the registered callbacks.
Fix this by propagating _get/put_device() down.
Brian, can we have this one queued for 4.9? I can't take it in my tree
if you want, but it's probably better if it's in the mtd tree.
Applied this patch to l2-mtd.git
I think this should also go into -stable.
Why? Do you have real use cases that are broken by this? I understand
I do, some code adding partitions on a gluebi master.
this is a problem, but I'm curious on how this satisfies the stable
rules.

Also, note that this isn't a regression; it's been broken forever and
apparently no one noticed. IMO that raises the bar a bit (but not
impossibly so) for -stable.
I just encountered the bug yesterday and yes it is obvious it has been
broken forever.
I don't have strong opinion about these things so no worries.

Karl
Anyway, if we decide to do this, you'll also want to include the git
hash and applicable kernel versions, per Option 2 [1].

Brian

[1] Documentation/stable_kernel_rules.txt.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help