Thread (134 messages) 134 messages, 4 authors, 2016-12-01
STALE3509d

[PATCH 3.12 095/127] drivers/vfio: Rework offsetofend()

From: Jiri Slaby <hidden>
Date: 2016-11-25 08:41:06
Also in: lkml
Subsystem: the rest, vfio driver · Maintainers: Linus Torvalds, Alex Williamson

From: Gavin Shan <redacted>

3.12-stable review patch.  If anyone has any objections, please let me know.

===============

commit b13460b92093b29347e99d6c3242e350052b62cd upstream.

The macro offsetofend() introduces unnecessary temporary variable
"tmp". The patch avoids that and saves a bit memory in stack.

Signed-off-by: Gavin Shan <redacted>
Signed-off-by: Alex Williamson <redacted>
Signed-off-by: Jiri Slaby <redacted>
---
 include/linux/vfio.h | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/include/linux/vfio.h b/include/linux/vfio.h
index 24579a0312a0..43f6bf4f8585 100644
--- a/include/linux/vfio.h
+++ b/include/linux/vfio.h
@@ -86,9 +86,8 @@ extern void vfio_unregister_iommu_driver(
  * from user space.  This allows us to easily determine if the provided
  * structure is sized to include various fields.
  */
-#define offsetofend(TYPE, MEMBER) ({				\
-	TYPE tmp;						\
-	offsetof(TYPE, MEMBER) + sizeof(tmp.MEMBER); })		\
+#define offsetofend(TYPE, MEMBER) \
+	(offsetof(TYPE, MEMBER)	+ sizeof(((TYPE *)0)->MEMBER))
 
 /*
  * External user API
-- 
2.10.2
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help