Re: [PATCH v2] media: solo6x10: fix lockup by avoiding delayed register write
From: khalasa@piap.pl (Krzysztof Hałasa)
Date: 2016-10-24 04:57:33
Also in:
linux-media, lkml
From: khalasa@piap.pl (Krzysztof Hałasa)
Date: 2016-10-24 04:57:33
Also in:
linux-media, lkml
Andrey Utkin [off-list ref] writes:
--- a/drivers/media/pci/solo6x10/solo6x10.h +++ b/drivers/media/pci/solo6x10/solo6x10.h@@ -284,7 +284,10 @@ static inline u32 solo_reg_read(struct solo_dev *solo_dev, int reg) static inline void solo_reg_write(struct solo_dev *solo_dev, int reg, u32 data) { + u16 val; + writel(data, solo_dev->reg_base + reg); + pci_read_config_word(solo_dev->pdev, PCI_STATUS, &val); } static inline void solo_irq_on(struct solo_dev *dev, u32 mask)
This is ok for now. I hope I will find some to refine this, so not all register writes are done with the penalty - eventually. -- Krzysztof Halasa Industrial Research Institute for Automation and Measurements PIAP Al. Jerozolimskie 202, 02-486 Warsaw, Poland