Thread (142 messages) 142 messages, 10 authors, 2016-10-13

[PATCH 3.4 109/125] ftrace/scripts: Fix incorrect use of sprintf in recordmcount

flat view
STALE3647d

From: lizf@kernel.org
Date: 2016-10-12 13:01:29
Also in: lkml
Subsystem: the rest · Maintainer: Linus Torvalds

From: Colin Ian King <redacted>

3.4.113-rc1 review patch.  If anyone has any objections, please let me know.

------------------


commit 713a3e4de707fab49d5aa4bceb77db1058572a7b upstream.

Fix build warning:

scripts/recordmcount.c:589:4: warning: format not a string
literal and no format arguments [-Wformat-security]
    sprintf("%s: failed\n", file);

Fixes: a50bd43935586 ("ftrace/scripts: Have recordmcount copy the object file")
Link: http://lkml.kernel.org/r/1451516801-16951-1-git-send-email-colin.king@canonical.com

Cc: Li Bin <redacted>
Cc: Russell King <redacted>
Cc: Will Deacon <redacted>
Signed-off-by: Colin Ian King <redacted>
Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
Signed-off-by: Zefan Li <redacted>
---
 scripts/recordmcount.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/scripts/recordmcount.c b/scripts/recordmcount.c
index 0970379..0d5ae4a 100644
--- a/scripts/recordmcount.c
+++ b/scripts/recordmcount.c
@@ -546,7 +546,7 @@ main(int argc, char *argv[])
 			do_file(file);
 			break;
 		case SJ_FAIL:    /* error in do_file or below */
-			sprintf("%s: failed\n", file);
+			fprintf(stderr, "%s: failed\n", file);
 			++n_error;
 			break;
 		case SJ_SUCCEED:    /* premature success */
-- 
1.9.1
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help