Thread (2 messages) 2 messages, 2 authors, 2016-08-14

Patch "ipath: Restrict use of the write() interface" has been added to the 4.4-stable tree

From: <gregkh@linuxfoundation.org>
Date: 2016-08-14 16:00:12

This is a note to let you know that I've just added the patch titled

    ipath: Restrict use of the write() interface

to the 4.4-stable tree which can be found at:
    http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
     ipath-restrict-use-of-the-write-interface.patch
and it can be found in the queue-4.4 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree,
please let [off-list ref] know about it.

From ben@decadent.org.uk  Sun Aug 14 16:54:26 2016
From: Ben Hutchings <redacted>
Date: Tue, 31 May 2016 03:33:57 +0100
Subject: ipath: Restrict use of the write() interface
To: stable@vger.kernel.org
Cc: Jason Gunthorpe <redacted>, Doug Ledford <redacted>, linux-rdma@vger.kernel.org
Message-ID: [ref]
Content-Disposition: inline

From: Ben Hutchings <redacted>

Commit e6bd18f57aad ("IB/security: Restrict use of the write()
interface") fixed a security problem with various write()
implementations in the Infiniband subsystem.  In older kernel versions
the ipath_write() function has the same problem and needs the same
restriction.  (The ipath driver has been completely removed upstream.)

Signed-off-by: Ben Hutchings <redacted>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
---
 drivers/staging/rdma/ipath/ipath_file_ops.c |    5 +++++
 1 file changed, 5 insertions(+)
--- a/drivers/staging/rdma/ipath/ipath_file_ops.c
+++ b/drivers/staging/rdma/ipath/ipath_file_ops.c
@@ -45,6 +45,8 @@
 #include <linux/uio.h>
 #include <asm/pgtable.h>
 
+#include <rdma/ib.h>
+
 #include "ipath_kernel.h"
 #include "ipath_common.h"
 #include "ipath_user_sdma.h"
@@ -2243,6 +2245,9 @@ static ssize_t ipath_write(struct file *
 	ssize_t ret = 0;
 	void *dest;
 
+	if (WARN_ON_ONCE(!ib_safe_file_access(fp)))
+		return -EACCES;
+
 	if (count < sizeof(cmd.type)) {
 		ret = -EINVAL;
 		goto bail;

Patches currently in stable-queue which might be from ben@decadent.org.uk are

queue-4.4/ipath-restrict-use-of-the-write-interface.patch
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help