Thread (192 messages) 192 messages, 6 authors, 2016-09-22
STALE3537d

[PATCH 3.10 176/180] ALSA: oxygen: Fix logical-not-parentheses warning

From: Willy Tarreau <w@1wt.eu>
Date: 2016-08-21 15:34:13
Also in: lkml
Subsystem: c-media cmi8788 driver, sound, the rest · Maintainers: Clemens Ladisch, Jaroslav Kysela, Takashi Iwai, Linus Torvalds

From: Tomer Barletz <redacted>

commit 8ec7cfce3762299ae289c384e281b2f4010ae231 upstream.

This fixes the following warning, that is seen with gcc 5.1:
warning: logical not is only applied to the left hand side of comparison [-Wlogical-not-parentheses].

Signed-off-by: Tomer Barletz <redacted>
Signed-off-by: Takashi Iwai <redacted>
Signed-off-by: Willy Tarreau <w@1wt.eu>
---
 sound/pci/oxygen/oxygen_mixer.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sound/pci/oxygen/oxygen_mixer.c b/sound/pci/oxygen/oxygen_mixer.c
index c0dbb52..1e4bcb9 100644
--- a/sound/pci/oxygen/oxygen_mixer.c
+++ b/sound/pci/oxygen/oxygen_mixer.c
@@ -88,7 +88,7 @@ static int dac_mute_put(struct snd_kcontrol *ctl,
 	int changed;
 
 	mutex_lock(&chip->mutex);
-	changed = !value->value.integer.value[0] != chip->dac_mute;
+	changed = (!value->value.integer.value[0]) != chip->dac_mute;
 	if (changed) {
 		chip->dac_mute = !value->value.integer.value[0];
 		chip->model.update_dac_mute(chip);
-- 
2.8.0.rc2.1.gbe9624a
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help