[PATCH REBASED v10 4/6] drm/i915/skl: Ensure pipes with changed wms get added to the state
flat view
DORMANTno replies
SUPERSEDED: 1 (0M)
From: Lyude <hidden>
Date: 2016-08-10 18:13:09
Also in:
dri-devel, intel-gfx, lkml
Subsystem:
drm drivers, intel drm i915 driver (meteor lake, dg2 and older excluding poulsbo, moorestown and derivative), the rest · Maintainers:
David Airlie, Simona Vetter, Jani Nikula, Joonas Lahtinen, Rodrigo Vivi, Tvrtko Ursulin, Linus Torvalds
Revision v10 of 9 in this series; 1 review trailer.
Revisions (9)
Possibly related (same subject, not in this thread)
- 2016-08-10 · [PATCH REBASED v10 4/6] drm/i915/skl: Ensure pipes with changed wms get added to the state · Lyude <hidden>
If we're enabling a pipe, we'll need to modify the watermarks on all active planes. Since those planes won't be added to the state on their own, we need to add them ourselves. Signed-off-by: Lyude <redacted> Reviewed-by: Matt Roper <redacted> Cc: stable@vger.kernel.org Cc: Ville Syrjälä <redacted> Cc: Daniel Vetter <redacted> Cc: Radhakrishna Sripada <redacted> Cc: Hans de Goede <redacted> --- drivers/gpu/drm/i915/intel_pm.c | 4 ++++ 1 file changed, 4 insertions(+)
diff --git a/drivers/gpu/drm/i915/intel_pm.c b/drivers/gpu/drm/i915/intel_pm.c
index df0fab6..165dc42 100644
--- a/drivers/gpu/drm/i915/intel_pm.c
+++ b/drivers/gpu/drm/i915/intel_pm.c@@ -4079,6 +4079,10 @@ skl_compute_ddb(struct drm_atomic_state *state) ret = skl_allocate_pipe_ddb(cstate, ddb); if (ret) return ret; + + ret = drm_atomic_add_affected_planes(state, &intel_crtc->base); + if (ret) + return ret; } return 0;
--
2.7.4