On Wed, 27 Jul 2016, Mike Travis wrote:
quoted hunk ↗ jump to hunk
Fix a problem that occurs if for some reason the UV4 EFI System Table
is not available, the check inadvertantly can cause a panic.
Reviewed-by: Dimitri Sivanich <redacted>
Reviewed-by: Nathan Zimmer <redacted>
Tested-by: Frank Ramsay <redacted>
Tested-by: John Estabrook <redacted>
Signed-off-by: Mike Travis <redacted>
---
arch/x86/platform/uv/bios_uv.c | 7 ++++---
1 file changed, 4 insertions(+), 3 deletions(-)
--- linux-3.12.orig/arch/x86/platform/uv/bios_uv.c
+++ linux-3.12/arch/x86/platform/uv/bios_uv.c
@@ -201,11 +201,12 @@ void uv_bios_init(void)
}
if (uv_systab->revision >= UV_SYSTAB_VERSION_UV4) {
+ int size = uv_systab->size;
+
iounmap(uv_systab);
- uv_systab = ioremap(efi.uv_systab, uv_systab->size);
I think the changelog is bogus. What's happening here is a classic use after
unmap, which you avoid by this change.
+ uv_systab = ioremap(efi.uv_systab, size);
Hmm?
tglx