Thread (6 messages) 6 messages, 4 authors, 2016-09-16

Re: [PATCH v2] fs/dcache.c: avoid soft-lockup in dput()

From: Wei Fang <hidden>
Date: 2016-07-06 02:36:25
Also in: linux-fsdevel, lkml

Hi, Boqun,
quoted
diff --git a/fs/dcache.c b/fs/dcache.c
index d5ecc6e..074fc1c 100644
--- a/fs/dcache.c
+++ b/fs/dcache.c
@@ -578,7 +578,7 @@ static struct dentry *dentry_kill(struct dentry *dentry)
 
 failed:
 	spin_unlock(&dentry->d_lock);
-	cpu_relax();
+	cond_resched();
Is it better to put the cond_resched() in the caller(i.e. dput()), right
before "goto repeat"? Because it's obviously a loop there, which makes
the purpose of cond_resched() more straightforward.
Agreed, that's more reasonable. I'll send v3 soon.

Thanks,
Wei
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help