Re: ktime_get_ts64() splat during resume

From
Rafael J. Wysocki <rafael@kernel.org>
Date
2016-06-17 15:28:15
Also in
linux-pm, lkml
Reply to
Borislav Petkov, 2016-06-17
On Fri, Jun 17, 2016 at 4:33 PM, Borislav Petkov [off-list ref] wrote:
Ok,

bisect is done, full log below.

Rafael, that fix

  70595b479ce1 ("x86/power/64: Fix crash whan the hibernation code passes control to the image kernel")

breaks s2disk here. It explodes during resume and a statically allocated
struct's member is NULL. See

https://lkml.kernel.org/r/20160617105435.GB15997@pd.tnic (local)

for the splat and some debugging attempts.

Reverting 70595b479ce1 fixes the issue here.
Quite evidently, memory is corrupted in the image kernel, but this
particular commit only affects the boot kernel, so it can't really
corrupt anything in the image one.

A couple of questions:
- I guess this is reproducible 100% of the time?
- If you do "echo disk > /sys/power/state" instead of using s2disk,
does it still crash in the same way?
- Are both the image and boot kernels the same binary?
@stable folk: You might want to hold off on picking up that one yet...


Now, I have serial connected to that box so if you want me to dump stuff
and try patches, let me know.

Btw, while I have your ear, can you pick up my einj fixes please?

:-)

-> https://lkml.kernel.org/r/1463992084-10012-1-git-send-email-bp@alien8.de (local)
Sure.  I thought Tony would pick them up.
Thread (16 messages) 16 messages, 7 authors, last reply 2016-06-21
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help