Thread (116 messages) 116 messages, 2 authors, 2016-03-31
STALE3770d REVIEWED: 6 (6M)

[patch added to 3.12-stable] devres: fix a for loop bounds check

From: Jiri Slaby <hidden>
Date: 2016-03-03 12:13:02
Subsystem: library code, the rest · Maintainers: Andrew Morton, Linus Torvalds

From: Dan Carpenter <redacted>

This patch has been added to the 3.12 stable tree. If you have any
objections, please let us know.

===============

commit 1f35d04a02a652f14566f875aef3a6f2af4cb77b upstream.

The iomap[] array has PCIM_IOMAP_MAX (6) elements and not
DEVICE_COUNT_RESOURCE (16).  This bug was found using a static checker.
It may be that the "if (!(mask & (1 << i)))" check means we never
actually go past the end of the array in real life.

Fixes: ec04b075843d ('iomap: implement pcim_iounmap_regions()')
Signed-off-by: Dan Carpenter <redacted>
Acked-by: Tejun Heo <tj@kernel.org>
Signed-off-by: Jiri Slaby <redacted>
Signed-off-by: Jiri Slaby <redacted>
---
 lib/devres.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/devres.c b/lib/devres.c
index 823533138fa0..20afaf181b27 100644
--- a/lib/devres.c
+++ b/lib/devres.c
@@ -423,7 +423,7 @@ void pcim_iounmap_regions(struct pci_dev *pdev, int mask)
 	if (!iomap)
 		return;
 
-	for (i = 0; i < DEVICE_COUNT_RESOURCE; i++) {
+	for (i = 0; i < PCIM_IOMAP_MAX; i++) {
 		if (!(mask & (1 << i)))
 			continue;
 
-- 
2.7.2
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help