Thread (5 messages) 5 messages, 4 authors, 2016-02-18

Re: [PATCH] pata-rb532-cf: get rid of the irq_to_gpio() call

From: Gabor Juhos <hidden>
Date: 2016-02-18 10:05:31
Also in: linux-ide

Hi Alban,
On Wed, 17 Feb 2016 12:58:20 +0100
Gabor Juhos [off-list ref] wrote:
quoted
The RB532 platform specific irq_to_gpio() implementation has been
removed with commit 832f5dacfa0b ("MIPS: Remove all the uses of
custom gpio.h"). Now the platform uses the generic stub which causes
the following error:

  pata-rb532-cf pata-rb532-cf: no GPIO found for irq149
  pata-rb532-cf: probe of pata-rb532-cf failed with error -2

Drop the irq_to_gpio() call and get the GPIO number from platform
data instead. After this change, the driver works again:
I think it would be preferable to move this driver to use the gpiod
API. The changes needed should be about the same size and it would
be a much more future proof fix.
The sole purpose of this patch is that to fix the breakage introduced in
832f5dacfa0b. Before that change, the driver was working without using the gpiod
API, and it is working again after this change.

Converting the driver to use the gpiod API needs more changes. Even if that is
preferable it should be implemented in separate patch(es) in my opinion.

-Gabor
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help