Re: [PATCH 1/3] nfit: fix multi-interface dimm handling, acpi6.1 compatibility

On Mon, Feb 8, 2016 at 12:23 PM, Linda Knippers [off-list ref] wrote:

On 2/8/2016 2:10 PM, Linda Knippers wrote:

quoted

On 2/8/2016 1:30 PM, Dan Williams wrote:

quoted

ACPI 6.1 clarified that multi-interface dimms require multiple control
region entries (DCRs) per dimm.  Previously we were assuming that a
control region is only present when block-data-windows are present.

We need to give this a quick test with NVDIMM-N because those types of
NVDIMMs have control regions without block-data-windows.  We've fixed
bugs related to that assumption a couple of times.

I can't test the conditions for which these changes were made but the
code continues to work on my NVDIMM-N system where we have control
regions w/o block-data windows.

Nice, thanks for the test report!  For my part I verified that the
implementation passes the original plus the modified unit test as
updated in [PATCH 3/3].