Thread (32 messages) 32 messages, 2 authors, 2016-01-28
STALE3813d

[patch added to 3.12-stable] ARM: 8160/1: drop warning about return_address not using unwind tables

From: Jiri Slaby <hidden>
Date: 2016-01-28 10:52:28
Subsystem: arm port, the rest · Maintainers: Russell King, Linus Torvalds

From: Uwe Kleine-König <redacted>

This patch has been added to the 3.12 stable tree. If you have any
objections, please let us know.

===============

commit e16343c47e4276f5ebc77ca16feb5e50ca1918f9 upstream.

The warning was introduced in 2009 (commit 4bf1fa5a34aa ([ARM] 5613/1:
implement CALLER_ADDRESSx)). The only "problem" here is that
CALLER_ADDRESSx for x > 1 returns NULL which doesn't do much harm.

The drawback of implementing a fix (i.e. use unwind tables to implement CALLER_ADDRESSx) is that much of the unwinder code would need to be marked as not
traceable.

Signed-off-by: Uwe Kleine-König <redacted>
Signed-off-by: Russell King <redacted>
Signed-off-by: Jiri Slaby <redacted>
---
 arch/arm/kernel/return_address.c | 4 ----
 1 file changed, 4 deletions(-)
diff --git a/arch/arm/kernel/return_address.c b/arch/arm/kernel/return_address.c
index f6aa84d5b93c..98ea4b7eb406 100644
--- a/arch/arm/kernel/return_address.c
+++ b/arch/arm/kernel/return_address.c
@@ -59,10 +59,6 @@ void *return_address(unsigned int level)
 
 #else /* if defined(CONFIG_FRAME_POINTER) && !defined(CONFIG_ARM_UNWIND) */
 
-#if defined(CONFIG_ARM_UNWIND)
-#warning "TODO: return_address should use unwind tables"
-#endif
-
 #endif /* if defined(CONFIG_FRAME_POINTER) && !defined(CONFIG_ARM_UNWIND) / else */
 
 EXPORT_SYMBOL_GPL(return_address);
-- 
2.7.0
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help