Thread (211 messages) 211 messages, 1 author, 2016-01-29
STALE3819d

[PATCH 3.19.y-ckt 164/210] kconfig: return 'false' instead of 'no' in bool function

From: Kamal Mostafa <hidden>
Date: 2016-01-29 01:38:24
Also in: lkml
Subsystem: kconfig, the rest · Maintainers: Nathan Chancellor, Nicolas Schier, Linus Torvalds

3.19.8-ckt14 -stable review patch.  If anyone has any objections, please let me know.

---8<------------------------------------------------------------

From: Vegard Nossum <redacted>

commit aab24a897cfba9dd371f6aac45dbcdae0b23def6 upstream.

menu_is_visible() is a bool function and should use boolean return
values. "no" is a tristate value which happens to also have a value
of 0, but we should nevertheless use the right symbol for it.

This is a very minor cleanup with no semantic change.

Fixes: 86e187ff9 ("kconfig: add an option to determine a menu's visibility")
Cc: Arnaud Lacombe <redacted>
Cc: Mauro Carvalho Chehab <redacted>
Signed-off-by: Vegard Nossum <redacted>
Signed-off-by: Michal Marek <redacted>
Signed-off-by: Kamal Mostafa <redacted>
---
 scripts/kconfig/menu.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/scripts/kconfig/menu.c b/scripts/kconfig/menu.c
index 72c9dba..876c45d 100644
--- a/scripts/kconfig/menu.c
+++ b/scripts/kconfig/menu.c
@@ -477,7 +477,7 @@ bool menu_is_visible(struct menu *menu)
 
 	if (menu->visibility) {
 		if (expr_calc_value(menu->visibility) == no)
-			return no;
+			return false;
 	}
 
 	sym = menu->sym;
-- 
1.9.1
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help