Thread (269 messages) 269 messages, 1 author, 2016-01-27
STALE3830d REVIEWED: 4 (1M)

[PATCH 4.2.y-ckt 209/268] tpm_tis: Use devm_free_irq not free_irq

From: Kamal Mostafa <hidden>
Date: 2016-01-27 20:58:33
Also in: lkml
Subsystem: the rest, tpm device driver · Maintainers: Linus Torvalds, Peter Huewe, Jarkko Sakkinen

4.2.8-ckt3 -stable review patch.  If anyone has any objections, please let me know.

---8<------------------------------------------------------------

From: Jason Gunthorpe <redacted>

commit 727f28b8ca24a581c7bd868326b8cea1058c720a upstream.

The interrupt is always allocated with devm_request_irq so it
must always be freed with devm_free_irq.

Fixes: 448e9c55c12d ("tpm_tis: verify interrupt during init")
Signed-off-by: Jason Gunthorpe <redacted>
Acked-by: Jarkko Sakkinen <redacted>
Tested-by: Jarkko Sakkinen <redacted>
Tested-by: Martin Wilck <redacted>
Signed-off-by: Jarkko Sakkinen <redacted>
Acked-by: Peter Huewe <peterhuewe@gmx.de>
Signed-off-by: Kamal Mostafa <redacted>
---
 drivers/char/tpm/tpm_tis.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/char/tpm/tpm_tis.c b/drivers/char/tpm/tpm_tis.c
index 19f9c7dc..60267d7 100644
--- a/drivers/char/tpm/tpm_tis.c
+++ b/drivers/char/tpm/tpm_tis.c
@@ -401,7 +401,7 @@ static void disable_interrupts(struct tpm_chip *chip)
 	iowrite32(intmask,
 		  chip->vendor.iobase +
 		  TPM_INT_ENABLE(chip->vendor.locality));
-	free_irq(chip->vendor.irq, chip);
+	devm_free_irq(chip->pdev, chip->vendor.irq, chip);
 	chip->vendor.irq = 0;
 }
 
-- 
1.9.1
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help