Thread (1 message) 1 message, 1 author, 2016-01-20
STALE3872d REVIEWED: 1 (0M)

1 review trailer.

[PATCH 3/4] perf stat: Do not clean event's private stats

From: Jiri Olsa <jolsa@kernel.org>
Date: 2016-01-20 11:56:50
Also in: lkml
Subsystem: performance events subsystem, the rest · Maintainers: Peter Zijlstra, Ingo Molnar, Arnaldo Carvalho de Melo, Namhyung Kim, Linus Torvalds

Mel reported stddev reporting was broken due to
following commit:
  106a94a0f8c2 perf stat: Introduce read_counters function

This commit merged interval and overall counters
reading into single read_counters function.

The old interval code cleaned the stddev data for
some reason (it's never displayed in interval mode)
and the mentioned commit kept on cleaning the stddev
data in merged function, which resulted in the stddev
not being displayed.

Removing the wrong stddev data cleanup init_stats call.

Reported-by: Mel Gorman <redacted>
Tested-by: Mel Gorman <redacted>
Cc: stable@vger.kernel.org # v4.2+
Cc: Mel Gorman <redacted>
Link: http://lkml.kernel.org/n/tip-tbcxtpjsqrrbwn2me0je8yxt@git.kernel.org
Signed-off-by: Jiri Olsa <jolsa@kernel.org>
---
 tools/perf/util/stat.c | 1 -
 1 file changed, 1 deletion(-)
diff --git a/tools/perf/util/stat.c b/tools/perf/util/stat.c
index 2f901d15e063..2b58edccd56f 100644
--- a/tools/perf/util/stat.c
+++ b/tools/perf/util/stat.c
@@ -310,7 +310,6 @@ int perf_stat_process_counter(struct perf_stat_config *config,
 	int i, ret;
 
 	aggr->val = aggr->ena = aggr->run = 0;
-	init_stats(ps->res_stats);
 
 	if (counter->per_pkg)
 		zero_per_pkg(counter);
-- 
2.4.3
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help