Thread (308 messages) 308 messages, 2 authors, 2016-01-19

[PATCH 4.2.y-ckt 228/305] drm/nouveau/bios/fan: hardcode the fan mode to linear

STALE3908d REVIEWED: 2 (0M)

From: Kamal Mostafa <hidden>
Date: 2016-01-16 00:29:27
Also in: lkml
Subsystem: drm driver for nvidia geforce/quadro gpus, drm drivers, drm drivers and misc gpu patches, the rest · Maintainers: Lyude Paul, Danilo Krummrich, David Airlie, Simona Vetter, Maarten Lankhorst, Maxime Ripard, Thomas Zimmermann, Linus Torvalds

2 review trailers.

4.2.8-ckt2 -stable review patch.  If anyone has any objections, please let me know.

---8<------------------------------------------------------------

From: Martin Peres <redacted>

commit a814a29d7bbfdfe56fe1bb9641a185077066eb9f upstream.

This is an oversight that made use of the trip-point-based fan managenent on
cards that never expose those. This led the fan to stay at fan_min.

Fortunately, the emergency code would kick when the temperature would reach
90°C.

Reported-by: Tom Englund <redacted>
Tested-by: Tom Englund <redacted>
Signed-off-by: Martin Peres <redacted>
Tested-by: Daemon32 <redacted>
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=92126
Signed-off-by: Ben Skeggs <redacted>
Signed-off-by: Kamal Mostafa <redacted>
---
 drivers/gpu/drm/nouveau/nvkm/subdev/bios/fan.c | 1 +
 1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/drm/nouveau/nvkm/subdev/bios/fan.c b/drivers/gpu/drm/nouveau/nvkm/subdev/bios/fan.c
index 8dba70d..e089752 100644
--- a/drivers/gpu/drm/nouveau/nvkm/subdev/bios/fan.c
+++ b/drivers/gpu/drm/nouveau/nvkm/subdev/bios/fan.c
@@ -83,6 +83,7 @@ nvbios_fan_parse(struct nvkm_bios *bios, struct nvbios_therm_fan *fan)
 			fan->type = NVBIOS_THERM_FAN_UNK;
 		}
 
+		fan->fan_mode = NVBIOS_THERM_FAN_LINEAR;
 		fan->min_duty = nv_ro08(bios, data + 0x02);
 		fan->max_duty = nv_ro08(bios, data + 0x03);
 
-- 
1.9.1
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help