On 08/27/2015 01:21 PM, David Vrabel wrote:

On 27/08/15 18:15, Marek Marczykowski-Górecki wrote:

quoted

quoted

On Thu, Aug 27, 2015 at 11:37:44AM -0400, Sasha Levin wrote:

quoted

quoted

From: Marek Marczykowski-Górecki <redacted>

This patch has been added to the 3.18 stable tree. If you have any
objections, please let us know.

On 3.18 it should be spin_lock, not mutex_lock.
Modified patch here:
https://raw.githubusercontent.com/QubesOS/qubes-linux-kernel/stable-3.18/patches.xen/0001-xen-grant-fix-race-condition-in-gntdev_release.patch

No.  Because this results in a sleep while holding the spin lock (in
free_xenballooned_pages()).

1401c00e59ea021c575f74612fe2dbba36d6a4ee (xen/gntdev: convert priv->lock
to a mutex) is a prerequisite.

Thanks! I've grabbed 1401c00e59e and re-pushed the queue.


Thanks,
Sasha