Thread (83 messages) 83 messages, 3 authors, 2015-08-15

[PATCH 4.1 16/84] drm/dp-mst: Remove debug WARN_ON

flat view
STALE4080d REVIEWED: 2 (0M)

From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Date: 2015-08-14 17:43:07
Also in: lkml

Revision v1 of 2 in this series; 2 review trailers.

Revisions (2)
  1. v1 current
  2. v1
4.1-stable review patch.  If anyone has any objections, please let me know.

------------------

From: Daniel Vetter <redacted>

commit 42639ba554655c280ae6cb72df0522b1201f2961 upstream.

Apparently been in there since forever and fairly easy to hit when
hotplugging really fast. I can do that since my mst hub has a manual
button to flick the hpd line for reprobing. The resulting WARNING spam
isn't pretty.

Cc: Dave Airlie <airlied@gmail.com>
Reviewed-by: Thierry Reding <redacted>
Reviewed-by: Ander Conselvan de Oliveira <redacted>
Signed-off-by: Daniel Vetter <redacted>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

---
 drivers/gpu/drm/drm_dp_mst_topology.c |    1 -
 1 file changed, 1 deletion(-)
--- a/drivers/gpu/drm/drm_dp_mst_topology.c
+++ b/drivers/gpu/drm/drm_dp_mst_topology.c
@@ -1294,7 +1294,6 @@ retry:
 				goto retry;
 			}
 			DRM_DEBUG_KMS("failed to dpcd write %d %d\n", tosend, ret);
-			WARN(1, "fail\n");
 
 			return -EIO;
 		}

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help