[PATCH 3.10 52/55] target/pscsi: Fix NULL pointer dereference in get_device_type
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Date: 2015-03-24 15:49:53
Also in:
lkml
3.10-stable review patch. If anyone has any objections, please let me know. ------------------ From: Nicholas Bellinger <redacted> commit 215a8fe4198f607f34ecdbc9969dae783d8b5a61 upstream. This patch fixes a NULL pointer dereference OOPs with pSCSI backends within target_core_stat.c code. The bug is caused by a configfs attr read if no pscsi_dev_virt->pdv_sd has been configured. Reported-by: Olaf Hering <redacted> Signed-off-by: Nicholas Bellinger <redacted> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> --- drivers/target/target_core_pscsi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
--- a/drivers/target/target_core_pscsi.c
+++ b/drivers/target/target_core_pscsi.c@@ -1112,7 +1112,7 @@ static u32 pscsi_get_device_type(struct struct pscsi_dev_virt *pdv = PSCSI_DEV(dev); struct scsi_device *sd = pdv->pdv_sd; - return sd->type; + return (sd) ? sd->type : TYPE_NO_LUN; } static sector_t pscsi_get_blocks(struct se_device *dev)