[PATCH 3.10 61/62] ACPI / video: Load the module even if ACPI is disabled
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Date: 2015-03-16 14:31:31
Also in:
lkml
3.10-stable review patch. If anyone has any objections, please let me know. ------------------ From: Chris Wilson <redacted> commit 6e17cb12881ba8d5e456b89f072dc6b70048af36 upstream. i915.ko depends upon the acpi/video.ko module and so refuses to load if ACPI is disabled at runtime if for example the BIOS is broken beyond repair. acpi/video provides an optional service for i915.ko and so we should just allow the modules to load, but do no nothing in order to let the machines boot correctly. Reported-by: Bill Augur <redacted> Signed-off-by: Chris Wilson <redacted> Cc: Daniel Vetter <redacted> Cc: Jani Nikula <redacted> Acked-by: Aaron Lu <redacted> [ rjw: Fixed up the new comment in acpi_video_init() ] Signed-off-by: Rafael J. Wysocki <redacted> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> --- drivers/acpi/video.c | 11 +++++++++++ 1 file changed, 11 insertions(+)
--- a/drivers/acpi/video.c
+++ b/drivers/acpi/video.c@@ -1953,6 +1953,17 @@ EXPORT_SYMBOL(acpi_video_unregister); static int __init acpi_video_init(void) { + /* + * Let the module load even if ACPI is disabled (e.g. due to + * a broken BIOS) so that i915.ko can still be loaded on such + * old systems without an AcpiOpRegion. + * + * acpi_video_register() will report -ENODEV later as well due + * to acpi_disabled when i915.ko tries to register itself afterwards. + */ + if (acpi_disabled) + return 0; + dmi_check_system(video_dmi_table); if (intel_opregion_present())