[PATCH 3.14 92/96] NFSv4: Dont call put_rpccred() under the rcu_read_lock()
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Date: 2015-03-16 14:52:25
Also in:
lkml
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Date: 2015-03-16 14:52:25
Also in:
lkml
3.14-stable review patch. If anyone has any objections, please let me know.
------------------
From: Trond Myklebust <redacted>
commit 7c0af9ffb7bb4e5355470fa60b3eb711ddf226fa upstream.
put_rpccred() can sleep.
Fixes: 8f649c3762547 ("NFSv4: Fix the locking in nfs_inode_reclaim_delegation()")
Signed-off-by: Trond Myklebust <redacted>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
---
fs/nfs/delegation.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- a/fs/nfs/delegation.c
+++ b/fs/nfs/delegation.c@@ -161,8 +161,8 @@ void nfs_inode_reclaim_delegation(struct &delegation->flags); NFS_I(inode)->delegation_state = delegation->type; spin_unlock(&delegation->lock); - put_rpccred(oldcred); rcu_read_unlock(); + put_rpccred(oldcred); trace_nfs4_reclaim_delegation(inode, res->delegation_type); } else { /* We appear to have raced with a delegation return. */