[PATCH 3.14 18/33] NFSv4.1: Fix an Oops in nfs41_walk_client_list
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Date: 2015-02-03 23:22:12
Also in:
lkml
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Date: 2015-02-03 23:22:12
Also in:
lkml
3.14-stable review patch. If anyone has any objections, please let me know. ------------------ From: Trond Myklebust <redacted> commit 3175e1dcec40fab1a444c010087f2068b6b04732 upstream. If we start state recovery on a client that failed to initialise correctly, then we are very likely to Oops. Reported-by: "Mkrtchyan, Tigran" <redacted> Link: http://lkml.kernel.org/r/130621862.279655.1421851650684.JavaMail.zimbra@desy.de Signed-off-by: Trond Myklebust <redacted> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> --- fs/nfs/nfs4client.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
--- a/fs/nfs/nfs4client.c
+++ b/fs/nfs/nfs4client.c@@ -633,7 +633,7 @@ int nfs41_walk_client_list(struct nfs_cl prev = pos; status = nfs_wait_client_init_complete(pos); - if (status == 0) { + if (pos->cl_cons_state == NFS_CS_SESSION_INITING) { nfs4_schedule_lease_recovery(pos); status = nfs4_wait_clnt_recover(pos); }