Thread (150 messages) 150 messages, 4 authors, 2015-01-15
STALE4201d REVIEWED: 1 (0M)

[PATCH 3.18 116/150] ARM: dts: am437x-sk: fix lcd enable pin mux data

From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Date: 2015-01-14 07:30:09
Also in: lkml

3.18-stable review patch.  If anyone has any objections, please let me know.

------------------

From: Felipe Balbi <redacted>

commit 58230c2c443bc9801293f6535144d04ceaf731e0 upstream.

Caused by a copy & paste error. Note that even with
this bug AM437x SK display still works because GPIO
mux mode is always enabled. It's still wrong to mux
somebody else's pin.

Luckily ball D25 (offset 0x238 - gpio5_8) on AM437x
isn't used for anything.

While at that, also replace a pullup with a pulldown
as that gpio should be normally low, not high.

Acked-by: Tomi Valkeinen <redacted>
Signed-off-by: Felipe Balbi <redacted>
Signed-off-by: Tony Lindgren <tony@atomide.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

---
 arch/arm/boot/dts/am437x-sk-evm.dts |    3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
--- a/arch/arm/boot/dts/am437x-sk-evm.dts
+++ b/arch/arm/boot/dts/am437x-sk-evm.dts
@@ -320,8 +320,7 @@
 
 	lcd_pins: lcd_pins {
 		pinctrl-single,pins = <
-			/* GPIO 5_8 to select LCD / HDMI */
-			0x238 (PIN_OUTPUT_PULLUP | MUX_MODE7)
+			0x1c (PIN_OUTPUT_PULLDOWN | MUX_MODE7) /* gpcm_ad7.gpio1_7 */
 		>;
 	};
 };

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help