Thread (19 messages) 19 messages, 4 authors, 2014-09-28

Re: [PATCH v2] vfs: Don't exchange "short" filenames unconditionally.

From: Al Viro <viro@ZenIV.linux.org.uk>
Date: 2014-09-24 20:18:13
Also in: linux-fsdevel, lkml

On Wed, Sep 24, 2014 at 12:20:38PM -0700, Linus Torvalds wrote:
On Wed, Sep 24, 2014 at 11:55 AM, Al Viro [off-list ref] wrote:
quoted
Yecchhhh...  Applied, but it's very ugly.  Oh, well - regression is
regression, and I don't see a cleaner fix at the moment.  If I don't
manage to come up with anything prettier, to Linus it goes in tonight
pull request ;-/
Please don't. That thing is too ugly to exist. It also looks
completely and utterly buggy. There's no way I'm taking it. If
switch-names is suddenly conditional, what the f*ck happens to the
name hash which is unconditionally done with a swap() right
afterwards.
The sucker's unhashed after that...  And yes, I agree that it's fucking
ugly.  Still looking for saner ways to do that...
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help