[PATCH 3.14 113/114] KEYS: Fix use-after-free in assoc_array_gc()
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Date: 2014-09-15 19:47:09
Also in:
lkml
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Date: 2014-09-15 19:47:09
Also in:
lkml
3.14-stable review patch. If anyone has any objections, please let me know. ------------------ From: David Howells <dhowells@redhat.com> commit 27419604f51a97d497853f14142c1059d46eb597 upstream. An edit script should be considered inaccessible by a function once it has called assoc_array_apply_edit() or assoc_array_cancel_edit(). However, assoc_array_gc() is accessing the edit script just after the gc_complete: label. Reported-by: Andreea-Cristina Bernat <redacted> Signed-off-by: David Howells <dhowells@redhat.com> Reviewed-by: Andreea-Cristina Bernat <redacted> cc: shemming@brocade.com cc: paulmck@linux.vnet.ibm.com Signed-off-by: James Morris <redacted> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> --- lib/assoc_array.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
--- a/lib/assoc_array.c
+++ b/lib/assoc_array.c@@ -1735,7 +1735,7 @@ ascend_old_tree: gc_complete: edit->set[0].to = new_root; assoc_array_apply_edit(edit); - edit->array->nr_leaves_on_tree = nr_leaves_on_tree; + array->nr_leaves_on_tree = nr_leaves_on_tree; return 0; enomem: