[PATCH 3.10 20/55] hwmon: (ads1015) Fix off-by-one for valid channel index checking
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Date: 2014-09-03 23:47:30
Also in:
lkml
3.10-stable review patch. If anyone has any objections, please let me know. ------------------ From: Axel Lin <redacted> commit 56de1377ad92f72ee4e5cb0faf7a9b6048fdf0bf upstream. Current code uses channel as array index, so the valid channel value is 0 .. ADS1015_CHANNELS - 1. Signed-off-by: Axel Lin <redacted> Signed-off-by: Guenter Roeck <linux@roeck-us.net> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> --- drivers/hwmon/ads1015.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
--- a/drivers/hwmon/ads1015.c
+++ b/drivers/hwmon/ads1015.c@@ -184,7 +184,7 @@ static int ads1015_get_channels_config_o } channel = be32_to_cpup(property); - if (channel > ADS1015_CHANNELS) { + if (channel >= ADS1015_CHANNELS) { dev_err(&client->dev, "invalid channel index %d on %s\n", channel, node->full_name);