Thread (6 messages) 6 messages, 3 authors, 2014-02-18

Re: [PATCH] workqueue: Document exceptions to work item non-reentrancy guarantee

From: Tejun Heo <tj@kernel.org>
Date: 2014-02-18 16:42:32
Also in: lkml

On Tue, Feb 18, 2014 at 11:31:18AM -0500, Peter Hurley wrote:
quoted
It's a pretty dumb thing to do anyway.
Fragile, yes; dumb, no. At least not from the point-of-view of the
documentation and what the workqueue actually did. But obviously from
your reaction, unintentional design.
Well, maybe dumb is too strong a word but these types of edge case
interfaces tend to cause subtle issues over time while being
marginally useful at best.  Sure it helps a couple odd users to write
slightly less code, but that's such a marginal gain compared to the
fragility it adds by being another one-off thing.  So, yeah, it's a
silly thing to include in an interface as widely use as workqueue and
it's more of a historical remanant than anything else at this point.

Thanks.

-- 
tejun
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help