[PATCH 3.12 105/133] net,via-rhine: Fix tx_timeout handling
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Date: 2014-02-04 22:06:14
Also in:
lkml
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Date: 2014-02-04 22:06:14
Also in:
lkml
3.12-stable review patch. If anyone has any objections, please let me know. ------------------ From: Richard Weinberger <richard@nod.at> [ Upstream commit a926592f5e4e900f3fa903298c4619a131e60963 ] rhine_reset_task() misses to disable the tx scheduler upon reset, this can lead to a crash if work is still scheduled while we're resetting the tx queue. Fixes: [ 93.591707] BUG: unable to handle kernel NULL pointer dereference at 0000004c [ 93.595514] IP: [<c119d10d>] rhine_napipoll+0x491/0x6 Signed-off-by: Richard Weinberger <richard@nod.at> Signed-off-by: David S. Miller <davem@davemloft.net> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> --- drivers/net/ethernet/via/via-rhine.c | 1 + 1 file changed, 1 insertion(+)
--- a/drivers/net/ethernet/via/via-rhine.c
+++ b/drivers/net/ethernet/via/via-rhine.c@@ -1615,6 +1615,7 @@ static void rhine_reset_task(struct work goto out_unlock; napi_disable(&rp->napi); + netif_tx_disable(dev); spin_lock_bh(&rp->lock); /* clear all descriptors */