Thread (97 messages) 97 messages, 1 author, 2014-01-13
STALE4571d REVIEWED: 1 (0M)

[PATCH 3.5 13/96] mm/hugetlb: check for pte NULL pointer in __page_check_address()

From: Luis Henriques <hidden>
Date: 2014-01-13 14:26:47
Also in: lkml
Subsystem: memory management, memory management - rmap (reverse mapping), the rest · Maintainers: Andrew Morton, David Hildenbrand, Lorenzo Stoakes, Linus Torvalds

3.5.7.29 -stable review patch.  If anyone has any objections, please let me know.

------------------

From: Jianguo Wu <redacted>

commit 98398c32f6687ee1e1f3ae084effb4b75adb0747 upstream.

In __page_check_address(), if address's pud is not present,
huge_pte_offset() will return NULL, we should check the return value.

Signed-off-by: Jianguo Wu <redacted>
Cc: Naoya Horiguchi <redacted>
Cc: Mel Gorman <mgorman@suse.de>
Cc: qiuxishi <redacted>
Cc: Hanjun Guo <guohanjun@huawei.com>
Acked-by: Kirill A. Shutemov <redacted>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
[ luis: backported to 3.5: adjusted context ]
Signed-off-by: Luis Henriques <redacted>
---
 mm/rmap.c | 4 ++++
 1 file changed, 4 insertions(+)
diff --git a/mm/rmap.c b/mm/rmap.c
index aa95e59..2b03b31 100644
--- a/mm/rmap.c
+++ b/mm/rmap.c
@@ -623,7 +623,11 @@ pte_t *__page_check_address(struct page *page, struct mm_struct *mm,
 	spinlock_t *ptl;
 
 	if (unlikely(PageHuge(page))) {
+		/* when pud is not present, pte will be NULL */
 		pte = huge_pte_offset(mm, address);
+		if (!pte)
+			return NULL;
+
 		ptl = &mm->page_table_lock;
 		goto check;
 	}
-- 
1.8.3.2
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help