Thread (33 messages) 33 messages, 1 author, 2013-06-11

[ 29/32] USB: ftdi_sio: Quiet sparse noise about using plain integer was NULL pointer

From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Date: 2013-06-11 20:27:00
Also in: lkml

3.4-stable review patch.  If anyone has any objections, please let me know.

------------------

From: Ying Xue <redacted>

commit a816e3113b63753c330ca4751ea1d208e93e3015 upstream.

Pointers should not be compared to plain integers.
Quiets the sparse warning:
warning: Using plain integer as NULL pointer

Signed-off-by: Ying Xue <redacted>
Cc: Lotfi Manseur <redacted>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

---
 drivers/usb/serial/ftdi_sio.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
--- a/drivers/usb/serial/ftdi_sio.c
+++ b/drivers/usb/serial/ftdi_sio.c
@@ -2173,7 +2173,7 @@ static void ftdi_set_termios(struct tty_
 
 	cflag = termios->c_cflag;
 
-	if (old_termios == 0)
+	if (!old_termios)
 		goto no_skip;
 
 	if (old_termios->c_cflag == termios->c_cflag

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help