On Thu, Jan 17, 2013 at 06:07:11PM -0200, Herton Ronaldo Krzesinski wrote:

On Tue, Jan 15, 2013 at 02:54:33PM -0800, Greg Kroah-Hartman wrote:

quoted

3.0-stable review patch.  If anyone has any objections, please let me know.

------------------

From: Theodore Ts'o <tytso@mit.edu>

commit 721e3eba21e43532e438652dd8f1fcdfce3187e7 upstream.

Commit c278531d39 added a warning when ext4_flush_unwritten_io() is
called without i_mutex being taken.  It had previously not been taken
during orphan cleanup since races weren't possible at that point in
the mount process, but as a result of this c278531d39, we will now see
a kernel WARN_ON in this case.  Take the i_mutex in
ext4_orphan_cleanup() to suppress this warning.

Reported-by: Alexander Beregalov <redacted>
Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
Reviewed-by: Zheng Liu <redacted>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

By the description and looking at commit c278531d39, this change isn't
needed for 3.0 or 3.4 kernels (anything <= 3.6), they don't contain
commit c278531d39.

Ah, good catch.  Should this be reverted from 3.0 and 3.4?

thanks,

greg k-h