Re: [PATCH] regulator: core: if voltage scaling fails, restore original voltage values

Hi,

On Fri, Dec 14, 2012 at 04:39:43PM +0100, Paolo Pisati wrote:

On Thu, Dec 13, 2012 at 11:47:15AM +0200, Felipe Balbi wrote:

quoted

On Thu, Dec 13, 2012 at 10:13:00AM +0100, Paolo Pisati wrote:

quoted

Signed-off-by: Paolo Pisati <redacted>
Tested-by: Robert Nelson <redacted>

please read Documentation/stable_kernel_rules.txt, you'll see this is
wrong.

you mean that i should have waited for the commit to hit Linus's tree before
cc-ing stable?

No no, I mean that before you SoB you should have a:

Cc: <redacted> # v3.x v3.y ...

Something like the commit below:

commit 041d81f493d90c940ec41f0ec98bc7c4f2fba431
Author: Felipe Balbi [off-list ref]
Date:   Thu Oct 4 11:58:00 2012 +0300

    usb: dwc3: gadget: fix 'endpoint always busy' bug
    
    If a USB transfer has already been started, meaning
    we have already issued StartTransfer command to that
    particular endpoint, DWC3_EP_BUSY flag has also
    already been set.
    
    When we try to cancel this transfer which is already
    in controller's cache, we will not receive XferComplete
    event and we must clear DWC3_EP_BUSY in order to allow
    subsequent requests to be properly started.
    
    The best place to clear that flag is right after issuing
    DWC3_DEPCMD_ENDTRANSFER.
    
    Cc: stable@vger.kernel.org # v3.4 v3.5 v3.6
    Reported-by: Moiz Sonasath [off-list ref]
    Signed-off-by: Felipe Balbi [off-list ref]


-- 
balbi