Thread (50 messages) 50 messages, 8 authors, 2012-12-06

Re: [ 12/37] ALSA: hda - Cirrus: Correctly clear line_out_pins when moving to speaker

From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Date: 2012-12-03 20:56:51
Also in: lkml

On Mon, Dec 03, 2012 at 10:46:59AM +0100, David Henningsson wrote:
On 11/30/2012 07:45 PM, Greg Kroah-Hartman wrote:
quoted
3.0-stable review patch.  If anyone has any objections, please let me know.

------------------

From: David Henningsson <redacted>

commit 34c3d1926bdaf45d3a891dd577482abcdd9faa34 upstream.

If this array is not cleared, the jack related code later might
fail to create "Internal Speaker Phantom Jack" on Dell Inspiron 3420 and
Dell Vostro 2420.

BugLink: https://bugs.launchpad.net/bugs/1076840
Signed-off-by: David Henningsson <redacted>
Signed-off-by: Takashi Iwai <redacted>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

---
 sound/pci/hda/patch_cirrus.c |    1 +
 1 file changed, 1 insertion(+)
--- a/sound/pci/hda/patch_cirrus.c
+++ b/sound/pci/hda/patch_cirrus.c
@@ -413,6 +413,7 @@ static int parse_output(struct hda_codec
 		memcpy(cfg->speaker_pins, cfg->line_out_pins,
 		       sizeof(cfg->speaker_pins));
 		cfg->line_outs = 0;
+		memset(cfg->line_out_pins, 0, sizeof(cfg->line_out_pins));
 	}

 	return 0;
This one was originally targeted for 3.6+ (as mentioned in my
original patch), for earlier kernels I don't anticipate it having
any effect, neither positive nor negative. Your call.
Ah, I messed up on that, sorry, I've dropped it from the 3.0-stable
queue now.

greg k-h
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help