Thread (103 messages) 103 messages, 2 authors, 2012-10-30

[ 063/101] USB: serial: Fix memory leak in sierra_release()

From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Date: 2012-10-29 22:06:53
Also in: lkml

3.6-stable review patch.  If anyone has any objections, please let me know.

------------------

From: Lennart Sorensen <redacted>

commit f7bc5051667b74c3861f79eed98c60d5c3b883f7 upstream.

I found a memory leak in sierra_release() (well sierra_probe() I guess)
that looses 8 bytes each time the driver releases a device.

Signed-off-by: Len Sorensen <redacted>
Acked-by: Johan Hovold <redacted>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

---
 drivers/usb/serial/sierra.c |    1 +
 1 file changed, 1 insertion(+)
--- a/drivers/usb/serial/sierra.c
+++ b/drivers/usb/serial/sierra.c
@@ -961,6 +961,7 @@ static void sierra_release(struct usb_se
 			continue;
 		kfree(portdata);
 	}
+	kfree(serial->private);
 }
 
 #ifdef CONFIG_PM

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help