Thread (15 messages) 15 messages, 4 authors, 2012-07-01

Re: [PATCH -stable] ntp: Correct TAI offset during leap second

From: Richard Cochran <richardcochran@gmail.com>
Date: 2012-06-18 16:29:09
Also in: lkml

On Mon, Jun 18, 2012 at 02:55:11PM +0100, Ben Hutchings wrote:
On Sun, 2012-06-17 at 19:34 +0200, Richard Cochran wrote:
quoted
The offset should change upon entering state OOP, so something like
the following (untested) patch should fix it for 3.2.9.
[...]

It looks like this patch just changes the offset reported by adjtimex()
during an inserted second; is that right?
Right, nothing really terrible will happen. The worst that I can
imagine is that ntpd will set the new TAI offset during OOP, and then
the kernel will add one to it, resulting in the TAI offset being off
by one.

But I really doubt any software makes use of this information.
Other than that, is 3.2.y likely to be OK?  Is there a good way to test
that in advance; does
<http://codemonkey.org.uk/2012/06/15/testing-leap-code/> look
reasonable?
Well, if you want to wait all night then that is one way to do it.
Here is a little test program I have been using:

   https://github.com/richardcochran/leap

Thanks,
Richard
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help