Thread (16 messages) 16 messages, 4 authors, 2012-06-21

Re: [PATCH] driver core: fix shutdown races with probe/remove(v2)

From: Alan Stern <stern@rowland.harvard.edu>
Date: 2012-06-11 16:02:36
Also in: lkml

On Mon, 11 Jun 2012, Ming Lei wrote:
On Mon, Jun 11, 2012 at 10:16 PM, Alan Stern [off-list ref] wrote:
quoted
quoted
+
+ � � � � � � if (nonlocked)
+ � � � � � � � � � � dev_err(dev, "can't hold %slock for shutdown\n",
+ � � � � � � � � � � � � � � � � � � nonlocked == 1 ? "" : "parent ");
Even if the parent can't be locked, you should still try to lock the
device.
I have considered doing it, but which may consume another 1sec.

Also if the parent lock has been held, it is very possibly that the
device can't be probed or removed at the same time, so just logged
the crazy thing and go ahead.
Okay.  Then you can add my Acked-by.

Alan Stern
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help