On Thu, 2012-06-07 at 23:11 -0400, Ted Ts'o wrote:

On Fri, Jun 08, 2012 at 04:03:09AM +0100, Ben Hutchings wrote:

quoted

quoted

 		ei->i_flags = flags;

[...]

Shouldn't this last assignment have been deleted?

Yes, I'm testing two patches to push to Linus.  One of them deletes
the last assignment.

The testing cycle should be over by tomorrow morning; in the mean
time, this commit is harmless in its current form (although it won't
fix the problem it was intending to fix until we delete the last
line).

[...]

It's not harmless because the user is no longer restricted to changing
EXT4_FL_USER_MODIFIABLE.

Ben.

-- 
Ben Hutchings
I haven't lost my mind; it's backed up on tape somewhere.