Thread (13 messages) 13 messages, 6 authors, 2012-06-11

Re: [patch 12/12] mm: correctly synchronize rss-counters at exit/exec

From: Markus Trippelsdorf <hidden>
Date: 2012-06-08 01:05:26
Also in: linux-mm, lkml

On 2012.06.07 at 17:25 -0700, Linus Torvalds wrote:
Ugh, looking more at the patch, I'm getting more and more convinces
that it is pure and utter garbage.

It does "sync_mm_rss(mm);" in mmput(), _after_ it has done the
possibly final mmdrop(). WTF?

This is crap, guys. Seriously. Stop playing russian rulette with this
code. I think we need to revert *all* of the crazy rss games, unless
Konstantin can show us some truly obviously correct fix.

Sadly, I merged and pushed out the crap before I had rebooted and
noticed this problem, so now it's in the wild. Can somebody please
take a look at this asap?
You've somehow merged the wrong patch.
The correct version can be found here:
http://marc.info/?l=linux-kernel&m=133848759505805

-- 
Markus
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help