Re: [PATCH] gpiolib: wm8994: Pay attention to the value set when enabling as output

From: Linus Walleij <hidden>
Date: 2012-06-07 11:11:23
Also in: lkml

On Tue, Jun 5, 2012 at 7:12 PM, Mark Brown
[off-list ref] wrote:

+ ï¿½ ï¿½ ï¿½ if (value)
+ ï¿½ ï¿½ ï¿½ ï¿½ ï¿½ ï¿½ ï¿½ value = WM8994_GPN_LVL;
+
ï¿½ ï¿½ ï¿½ ï¿½return wm8994_set_bits(wm8994, WM8994_GPIO_1 + offset,
- ï¿½ ï¿½ ï¿½ ï¿½ ï¿½ ï¿½ ï¿½ ï¿½ ï¿½ ï¿½ ï¿½ ï¿½ ï¿½ ï¿½ ï¿½WM8994_GPN_DIR, 0);
+ ï¿½ ï¿½ ï¿½ ï¿½ ï¿½ ï¿½ ï¿½ ï¿½ ï¿½ ï¿½ ï¿½ ï¿½ ï¿½ ï¿½ ï¿½WM8994_GPN_DIR | WM8994_GPN_LVL, value);
ï¿½}

The commit message is so terse compared to what the code does that
I cannot claim to understand what this patch is doing.

Could you elaborate on the problem ans symptoms, just for a nice
commit log?

Yours,
Linus Walleij

`h`	back out one level
`j`	next message in thread
`k`	previous message in thread
`l`	drill in
`Esc`	close help / fold thread tree
`?`	toggle this help