Re: [PATCH] hw_random: atmel-rng: fix race condition leading to repeated bits
From: Herbert Xu <herbert@gondor.apana.org.au>
Date: 2012-05-31 10:55:14
Also in:
lkml
From: Herbert Xu <herbert@gondor.apana.org.au>
Date: 2012-05-31 10:55:14
Also in:
lkml
On Fri, May 25, 2012 at 11:12:38AM +0200, Peter Korsgaard wrote:
Data valid gets cleared by reading the ISR (status register) and NOT from reading ODATA (data register). A new data word can become available between checking ISR and reading ODATA, causing us to reuse the same data word next time atmel_trng_read() gets called, if that happens before the following data word is ready.
Patch applied crypto. Thanks! -- Email: Herbert Xu [off-list ref] Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt