Thread (9 messages) 9 messages, 4 authors, 2012-05-18

Re: [PATCH] slub: fix a memory leak in get_partial_node()

From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Date: 2012-05-16 14:50:40
Also in: linux-mm, lkml

On Wed, May 16, 2012 at 10:56:50PM +0900, JoonSoo Kim wrote:
2012/5/16 Pekka Enberg [off-list ref]:
quoted
<On Tue, 15 May 2012, Christoph Lameter wrote:
quoted
On Wed, 16 May 2012, Joonsoo Kim wrote:
quoted
In the case which is below,

1. acquire slab for cpu partial list
2. free object to it by remote cpu
3. page->freelist = t

then memory leak is occurred.
Hmmm... Ok so we cannot assign page->freelist in get_partial_node() for
the cpu partial slabs. It must be done in the cmpxchg transition.

Acked-by: Christoph Lameter <redacted>
Joonsoo, can you please fix up the stable submission format, add
Christoph's ACK and resend?

� � � � � � � � � � � �Pekka
Thanks for comment.
I'm a kernel newbie,
so could you please tell me how to fix up the stable submission format?
I'm eager to fix it up, but I don't know how to.

I read stable_kernel_rules.txt, this article tells me I must note
upstream commit ID.
Above patch is not included in upstream currently, so I can't find
upstream commit ID.
Is 'Acked-by from MAINTAINER' sufficient for submitting to stable-kernel?
Is below format right for stable submission format?
No.

Please read the second item in the list that says: "Procedure for
submitting patches to the -stable tree" in the file,
Documentation/stable_kernel_rulest.txt.  It states:

 - To have the patch automatically included in the stable tree, add the tag
     Cc: stable@vger.kernel.org
   in the sign-off area. Once the patch is merged it will be applied to
   the stable tree without anything else needing to be done by the author
   or subsystem maintainer.

Does that help?

thanks,

greg k-h
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help