Thread (193 messages) 193 messages, 8 authors, 2012-05-12

[ 142/167] [PATCH] i2c: pnx: Disable clk in suspend

From: Ben Hutchings <hidden>
Date: 2012-05-09 06:09:09
Also in: lkml
Subsystem: arm/lpc32xx soc support, i2c subsystem, i2c subsystem host drivers, the rest · Maintainers: Vladimir Zapolskiy, Piotr Wojtaszczyk, Andi Shyti, Linus Torvalds

3.2-stable review patch.  If anyone has any objections, please let me know.

------------------

From: Roland Stigge <redacted>

commit 6c557cfee08751d22aed34840f389b846f0f4508 upstream.

In the driver's suspend function, clk_enable() was used instead of
clk_disable(). This is corrected with this patch.

Signed-off-by: Roland Stigge <redacted>
Reviewed-by: Arnd Bergmann <arnd@arndb.de>

[wsa: reworded commit header slightly]

Signed-off-by: Wolfram Sang <redacted>
Signed-off-by: Ben Hutchings <redacted>
---
 drivers/i2c/busses/i2c-pnx.c |    3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/i2c/busses/i2c-pnx.c b/drivers/i2c/busses/i2c-pnx.c
index 04be9f8..eb8ad53 100644
--- a/drivers/i2c/busses/i2c-pnx.c
+++ b/drivers/i2c/busses/i2c-pnx.c
@@ -546,8 +546,7 @@ static int i2c_pnx_controller_suspend(struct platform_device *pdev,
 {
 	struct i2c_pnx_algo_data *alg_data = platform_get_drvdata(pdev);
 
-	/* FIXME: shouldn't this be clk_disable? */
-	clk_enable(alg_data->clk);
+	clk_disable(alg_data->clk);
 
 	return 0;
 }
-- 
1.7.10


Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help