Re: Patch Upstream: module: Remove module size limit
From: Rusty Russell <hidden>
Date: 2012-03-29 04:55:20
On Wed, 28 Mar 2012 16:32:52 -0700, Greg KH [off-list ref] wrote:
On Thu, Mar 29, 2012 at 01:22:23AM +0200, Sasha Levin wrote:quoted
On Thu, Mar 29, 2012 at 1:09 AM, Greg KH [off-list ref] wrote:quoted
On Thu, Mar 29, 2012 at 12:57:47AM +0200, Sasha Levin wrote:quoted
On Thu, Mar 29, 2012 at 12:41 AM, Greg KH [off-list ref] wrote:quoted
For the patch below, what are the "real world use cases" that would cause this to be needed in the stable kernel trees? Is there an in-kernel module that is affected by this limitation?There are no in-kernel modules which are affected, the "real world" scenario is debug modules generated by Ksplice.So why is this needed for the stable kernels? This really looks like a feature not a bugfix to me, how about you?I guess it depends on whether you consider the inability to load modules bigger than 64mb as a bug or not.As there is no in-kernel user with this problem, no, I don't think it's a bug that meets the rules documented in Documentation/stable_kernel_rules.txt, do you?
Your call, but it has been my policy to support ksplice, such as making sure we export symbols it needs. And this really is a low-risk change. Thanks, Rusty. -- How could I marry someone with more hair than me? http://baldalex.org