[ 069/149] md/bitmap: ensure to load bitmap when creating via sysfs.
From: Greg KH <gregkh@linuxfoundation.org>
Date: 2012-03-30 22:21:43
Also in:
lkml
From: Greg KH <gregkh@linuxfoundation.org>
Date: 2012-03-30 22:21:43
Also in:
lkml
3.2-stable review patch. If anyone has any objections, please let me know. ------------------ From: NeilBrown <redacted> commit 4474ca42e2577563a919fd3ed782e2ec55bf11a2 upstream. When commit 69e51b449d383e (md/bitmap: separate out loading a bitmap...) created bitmap_load, it missed calling it after bitmap_create when a bitmap is created through the sysfs interface. So if a bitmap is added this way, we don't allocate memory properly and can crash. This is suitable for any -stable release since 2.6.35. Signed-off-by: NeilBrown <redacted> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> --- drivers/md/bitmap.c | 2 ++ 1 file changed, 2 insertions(+)
--- a/drivers/md/bitmap.c
+++ b/drivers/md/bitmap.c@@ -1904,6 +1904,8 @@ location_store(struct mddev *mddev, cons if (mddev->pers) { mddev->pers->quiesce(mddev, 1); rv = bitmap_create(mddev); + if (!rv) + rv = bitmap_load(mddev); if (rv) { bitmap_destroy(mddev); mddev->bitmap_info.offset = 0;