[ 077/175] tcm_fc: Fix fc_exch memory leak in ft_send_resp_status
From: Greg KH <gregkh@linuxfoundation.org>
Date: 2012-03-30 21:48:08
Also in:
lkml
3.3-stable review patch. If anyone has any objections, please let me know. ------------------ From: Nicholas Bellinger <redacted> commit 031ed4d565b31880a4136bb7366bc89f5b1dba7d upstream. This patch fixes a bug in tcm_fc where fc_exch memory from fc_exch_mgr->ep_pool is currently being leaked by ft_send_resp_status() usage. Following current code in ft_queue_status() response path, using lport->tt.seq_send() needs to be followed by a lport->tt.exch_done() in order to release fc_exch memory back into libfc_em kmem_cache. ft_send_resp_status() code is currently used in pre submit se_cmd ft_send_work() error exceptions, TM request setup exceptions, and main TM response callback path in ft_queue_tm_resp(). This bugfix addresses the leak in these cases. Cc: Mark D Rustad <redacted> Cc: Kiran Patil <redacted> Cc: Robert Love <redacted> Cc: Andy Grover <redacted> Signed-off-by: Nicholas Bellinger <redacted> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> --- drivers/target/tcm_fc/tfc_cmd.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-)
--- a/drivers/target/tcm_fc/tfc_cmd.c
+++ b/drivers/target/tcm_fc/tfc_cmd.c@@ -325,10 +325,12 @@ static void ft_send_resp_status(struct f fc_fill_reply_hdr(fp, rx_fp, FC_RCTL_DD_CMD_STATUS, 0); sp = fr_seq(fp); - if (sp) + if (sp) { lport->tt.seq_send(lport, sp, fp); - else + lport->tt.exch_done(sp); + } else { lport->tt.frame_send(lport, fp); + } } /*