[ 10/38] vfs: fix return value from do_last()
From: Greg KH <gregkh@linuxfoundation.org>
Date: 2012-03-16 23:58:37
Also in:
lkml
From: Greg KH <gregkh@linuxfoundation.org>
Date: 2012-03-16 23:58:37
Also in:
lkml
3.0-stable review patch. If anyone has any objections, please let me know. ------------------ From: Miklos Szeredi <redacted> commit 7f6c7e62fcc123e6bd9206da99a2163fe3facc31 upstream. complete_walk() returns either ECHILD or ESTALE. do_last() turns this into ECHILD unconditionally. If not in RCU mode, this error will reach userspace which is complete nonsense. Signed-off-by: Miklos Szeredi <redacted> Signed-off-by: Al Viro <viro@zeniv.linux.org.uk> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> --- fs/namei.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
--- a/fs/namei.c
+++ b/fs/namei.c@@ -2109,7 +2109,7 @@ static struct file *do_last(struct namei /* sayonara */ error = complete_walk(nd); if (error) - return ERR_PTR(-ECHILD); + return ERR_PTR(error); error = -ENOTDIR; if (nd->flags & LOOKUP_DIRECTORY) {