[ 30/73] net_sched: Bug in netem reordering
From: Greg KH <gregkh@linuxfoundation.org>
Date: 2012-02-28 01:38:47
Also in:
lkml
3.0-stable review patch. If anyone has any objections, please let me know. ------------------ From: Hagen Paul Pfeifer <redacted> [ Upstream commit eb10192447370f19a215a8c2749332afa1199d46 ] Not now, but it looks you are correct. q->qdisc is NULL until another additional qdisc is attached (beside tfifo). See 50612537e9ab2969312. The following patch should work. From: Hagen Paul Pfeifer <redacted> netem: catch NULL pointer by updating the real qdisc statistic Reported-by: Vijay Subramanian <redacted> Signed-off-by: Hagen Paul Pfeifer <redacted> Acked-by: Eric Dumazet <redacted> Signed-off-by: David S. Miller <davem@davemloft.net> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> --- net/sched/sch_netem.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
--- a/net/sched/sch_netem.c
+++ b/net/sched/sch_netem.c@@ -381,8 +381,8 @@ static int netem_enqueue(struct sk_buff q->counter = 0; __skb_queue_head(&q->qdisc->q, skb); - q->qdisc->qstats.backlog += qdisc_pkt_len(skb); - q->qdisc->qstats.requeues++; + sch->qstats.backlog += qdisc_pkt_len(skb); + sch->qstats.requeues++; ret = NET_XMIT_SUCCESS; }